Repository navigation
[Visibility] Deprecate ChangeConstantVisibilityRector as too niche and risky - #8767
Merged
Merged
Conversation
…d risky to visibility across parent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeConstantVisibilityRector is too niche and never used in practice.
Changing a constant visibility against its parent class needs extra care to not break the code, e.g. widening a parent's
protectedconstant topublicon a child, or the reverse that can make an inherited constant inaccessible.For such a case, a custom rule tailored to the concrete constants and classes is safer than this generic one.
Follows the usual full-retirement pattern: marks the rule
@deprecated+DeprecatedInterface, guts the body to throw, drops the now-unusedChangeConstantVisibilityvalue object and the rule test.